Migrate existing organizations state from StateService → StateProvider
#7895
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Mar 15, 2024 in 55s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Code Duplication state.service.ts: StateService.setOrganizations 🔥
- Lines of Code in a Single File state.service.ts 🔥
- Number of Functions in a Single Module state.service.ts 🔥
Annotations
Check notice on line 1 in libs/common/src/platform/services/state.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1774 to 1756, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1 in libs/common/src/platform/services/state.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Number of Functions in a Single Module
The number of functions decreases from 192 to 190, threshold = 75. This file contains too many functions. Beyond a certain threshold, more functions lower the code health.
Check notice on line 1 in libs/common/src/platform/services/state.service.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Code Duplication
reduced similar code in: StateService.setOrganizations. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.