Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debugging messages #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abravalheri
Copy link

Although errors and warnings are being logged, some times the strategies
result in empty sets of nodes. Being able to see more information in the
logs is helpful to troubleshoot complex cluster systems.

Although errors and warnings are being logged, some times the strategies
result in empty sets of nodes. Being able to see more information in the
logs is helpful to troubleshoot complex cluster systems.
@beardedeagle
Copy link

Please fix conflcts @abravalheri

@abravalheri
Copy link
Author

Hi @beardedeagle, thank you for the message. Before rushing to fix the conflicts, did you had the chance to have a quick look at the proposed changes? Do they make sense? I wonder if that is the best way to go, or something different would be the best (e.g. using the default Elixir logger, or relying on macros to eliminate overhead).

(Sorry this was submitted 1 year ago, and since I had no interactions from the maintainers I thought maybe the design of this change was inconsistent with their long-term vision)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants