Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSSRV strategy not compatible with kube-dns #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mergefailure
Copy link

since google kubernetes switched from core-dns to kube-dns - this no longer works, just causes confusion.

since google kubernetes switched from core-dns to kube-dns - this no longer works, just causes confusion.
@bitwalker
Copy link
Owner

What is the recommended alternative? If you have a suggestion or link to the appropriate changelog, I'm happy to take it from there.

In any case, PRs to remove a strategy aren't merged. This library uses a deprecation cycle to remove APIs or implementations; so unless we can update this strategy to transparently work with the changes in k8s, we'd need to keep it around for backwards-comptability for at least one major release.

@bitwalker bitwalker changed the title This was cute - but no use any more DNSSRV strategy not compatible with kube-dns Apr 24, 2020
@seivan
Copy link
Contributor

seivan commented Apr 24, 2020

I haven't tested DNSSRV, and I wouldn't recommend it unless you really can't afford/use a headless services, I am not sure it's a good idea to remove it for people running older clusters. But I am questioning merging the implementations in #115 but I'd love to get some answers first.

The thing is....
EKS is notorious for lagging and before 1.10 kube-dns was the default one, until 1.12 which replaced it with CoreDNS

since google kubernetes switched from core-dns to kube-dns

1. Why would that make it break?
2. Could you link to an official statement saying that?

Sometimes when printing resources in a cluster, it might say kube-dns, but that doesn't mean it's not runningCoreDNS (see EKS).

Edit: This issue answers the questions: #121

antonmi added a commit to antonmi/cluster that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants