Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestMsgServerUpdateMetadataAuthority suggestions #201

Open
giorgionocera opened this issue Oct 1, 2022 · 0 comments
Open

TestMsgServerUpdateMetadataAuthority suggestions #201

giorgionocera opened this issue Oct 1, 2022 · 0 comments
Labels

Comments

@giorgionocera
Copy link
Contributor

In the nft module, in the nft/keeper/msg_server_test.go file, lays the TestMsgServerUpdateMetadataAuthority method. This method implements the tests for updating metadata authority

Here, it is possible to change authority also for immutable metadata as discussed in #200. We need to understand if it is normal behavior. Moreover, as expressed in #188 no check is done on addresses, so they could also be empty strings.

In the end, as discussed in point 3 of #159, we could analyze whether it would not be more convenient to remove the isMutable attribute and, use an address (isMutable = true) or an empty string (isMutable = false) for the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant