Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateMetadataAuthority and not mutable metadata #200

Open
giorgionocera opened this issue Oct 1, 2022 · 1 comment
Open

UpdateMetadataAuthority and not mutable metadata #200

giorgionocera opened this issue Oct 1, 2022 · 1 comment
Assignees
@ryusmo
Labels
bug Something isn't working high-priority NFT question Further information is requested

Comments

@giorgionocera
Copy link
Contributor

In the nft module, ATM the UpdateMetadataAuthority method is able to modify the MetadataAuthority even if the metadata is mutable no more (isMutable = false).
The method is also involved in issue #188.
IMHO, once the metadata is mutable no more (the isMutable attribute is set to false), neither the MetadataAuthorityshould be able to change.
What do you think?
@giorgionocera giorgionocera mentioned this issue Oct 1, 2022
Open
@giorgionocera giorgionocera added bug Something isn't working question Further information is requested NFT labels Oct 6, 2022
@giorgionocera
Copy link
Contributor Author

After a meeting with @angelorc , he agrees with this vision. Moreover, he also agrees with the fact of using the MetadataAuthorithy value to verify if it is mutable or not (empty address corresponds to isMutable = false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryusmo ryusmo

Labels
bug Something isn't working high-priority NFT question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@angelorc @giorgionocera @ryusmo