Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfc 0002 data types #46

Open
wants to merge 3 commits into
base: dev_v3
Choose a base branch
from
Open

Conversation

pflooky
Copy link

@pflooky pflooky commented May 13, 2024

Changes for making data types based on OpenAPI.

  • Add in dataset.column.logicalTypeOptions (based on OpenAPI data type options)
  • Restrict dataset.column.logicalType to one of string, number, integer, object, array or boolean
  • Add in an example of all data types

Copy link

@destouma destouma May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add format :
for number: float, double
for interger: int32, int16

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can. It will be nicer than users having to revert to using maximum and minimum.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm looking around to see if there is a set of existing formats we could leverage.
We could follow the same formats as prescribed by:

  • Postgres
    • smallint, integer, bigint, ...
  • Rust
    • i8, u8, i16, u16, ...
  • Protobuf
    • int32, int64, uint32, uint64, sint32, sint64, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants