Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/nginx] Changed default type to ClusterIP. #25084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kometen
Copy link

@kometen kometen commented Apr 9, 2024

Description of the change

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort.

Could you please add a description of the necessity of this change?

Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Apart from that, could you please bump the chart version in the Chart.yaml file?

Feel free to reach out if you have any questions or need assistance with the signing process.

@kometen
Copy link
Author

kometen commented Apr 9, 2024

Hi. Thank you for your kind response.

Many, or some, :-) will deploy this nginx helm chart with an already existing ingress service in place. So it makes more sense to have the service type to ClusterIP rather than LoadBalancer as default.

I had a similar issus as this closed issue at #11846.

Thank you.

@kometen kometen changed the title Changed default type to ClusterIP. [bitnami/nginx] Changed default type to ClusterIP. Apr 11, 2024
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Apr 27, 2024
Copy link

github-actions bot commented May 2, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nginx solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/nginx] Changed the default type from LoadBalancer to ClusterIP
2 participants