Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {} #24645

Merged
merged 1 commit into from Mar 25, 2024
Merged

[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {} #24645

merged 1 commit into from Mar 25, 2024

Conversation

javsalgar
Copy link
Contributor

Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com

Description of the change

This PR sets seLinuxOptions to {} to avoid issues with kubectl diff

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@javsalgar
[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {}
86b02d5 
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 25, 2024
@javsalgar javsalgar requested review from fmulero and removed request for aoterolorenzo March 25, 2024 10:09
@javsalgar javsalgar assigned fmulero and unassigned aoterolorenzo Mar 25, 2024
fmulero
fmulero approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javsalgar javsalgar merged commit 916e478 into main Mar 25, 2024
21 checks passed
@javsalgar javsalgar deleted the fix/zookeeper-selinuxopts branch March 25, 2024 10:49
aneurinprice pushed a commit to aneurinprice/bitnami-charts that referenced this pull request Mar 25, 2024
@javsalgar @aneurinprice
[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {} (bitnami#24645)
2db3a5c 
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: AneurinPrice <adp@nyeprice.space>
aneurinprice pushed a commit to aneurinprice/bitnami-charts that referenced this pull request Mar 25, 2024
@javsalgar @aneurinprice
[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {} (bitnami#24645)
4714cf9 
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: AneurinPrice <adp@nyeprice.space>
djjudas21 pushed a commit to djjudas21/bitnami-charts that referenced this pull request Apr 17, 2024
@javsalgar @djjudas21
[bitnami/zookeeper] fix: 🐛 Set seLinuxOptions to {} (bitnami#24645)
0046459 
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
bitnami solved verify Execute verification workflow for these changes zookeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/kube-prometheus] seLinuxOptions defaults are not valid
4 participants
@javsalgar @fmulero @aoterolorenzo @bitnami-bot