fix: missing common annotations in the helm chart #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrgim
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
cyrgim
force-pushed
the
fix-helm-common-annotations
branch
from
74b2694
to
50bf8e4
Compare
alemorcuq
requested changes
Feb 29, 2024
cyrgim
force-pushed
the
fix-helm-common-annotations
branch
2 times, most recently
from
fe00797
to
0853828
Compare
alemorcuq
requested changes
Mar 1, 2024
Signed-off-by: cyrgim <migeon.work@gmail.com>
cyrgim
force-pushed
the
fix-helm-common-annotations
branch
from
0853828
to
5aa05e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add common annotations to all resources in the helm chart as per the documentation:
## @param commonAnnotations [object] Annotations to add to all deployed resourcesBenefits
Add common annotations to all resources in the helm chart as per the documentation
Applicable issues
commonAnnotationsare not implemented for all resources #1372