Add option for custom annotations and labels on sealing keypairs #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karel Vanden Houte <karel.vandenhoute@gmail.com>
kvandenhoute
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
|
hi @kvandenhoute, thanks a lot for your new contribution. Testing it, coming back ASAP with feedback 😄 |
alvneiayu
reviewed
Jun 27, 2023
alvneiayu
reviewed
Jun 27, 2023
|
I included minor comments. Tested it and it is working like a charm. Thanks again @kvandenhoute |
Co-authored-by: Alvaro Neira Ayuso <alvaroneay@gmail.com> Signed-off-by: kvandenhoute <karel.vandenhoute@gmail.com>
Co-authored-by: Alvaro Neira Ayuso <alvaroneay@gmail.com> Signed-off-by: kvandenhoute <karel.vandenhoute@gmail.com>
alvneiayu
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add possibility to add labels / annotations to the generated keypairs to seal secrets
Benefits
The usual benefit of labels and annotations
Possible drawbacks
None
Applicable issues
#949
Additional information
I don't know whether privatekey-labels and privatekey-annotations are a good naming choice, I just used the ones from the issue