Skip to content

Commit

Permalink
fix(helm): role binding annotations (#1494)
Browse files Browse the repository at this point in the history
**Description of the change**
Use the right context for `commonAnnotations` in namespaced role
bindings.

**Benefits**
Fix a bug preventing namespaced role bindings to be created.

**Applicable issues**
- fixes #1493

Signed-off-by: Alejandro Moreno <amorenoc@vmware.com>
  • Loading branch information
alemorcuq committed Mar 21, 2024
1 parent 23b8c25 commit a0e1499
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion helm/sealed-secrets/Chart.yaml
Expand Up @@ -14,6 +14,6 @@ maintainers:
url: https://github.com/bitnami-labs/sealed-secrets
name: sealed-secrets
type: application
version: 2.15.1
version: 2.15.2
sources:
- https://github.com/bitnami-labs/sealed-secrets
4 changes: 2 additions & 2 deletions helm/sealed-secrets/templates/role-binding.yaml
Expand Up @@ -63,8 +63,8 @@ metadata:
{{- include "sealed-secrets.render" ( dict "value" $.Values.rbac.labels "context" $) | nindent 4 }}
{{- end }}
annotations:
{{- if .Values.commonAnnotations }}
{{- include "sealed-secrets.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
{{- if $.Values.commonAnnotations }}
{{- include "sealed-secrets.render" ( dict "value" $.Values.commonAnnotations "context" $ ) | nindent 4 }}
{{- end }}
roleRef:
apiGroup: rbac.authorization.k8s.io
Expand Down

0 comments on commit a0e1499

Please sign in to comment.