Skip to content

Commit

Permalink
Merge #194
Browse files Browse the repository at this point in the history
194: Ensure image pull policy is not Never r=mkmik a=mkmik

In #181 we made sure the CI was always testing the rigth code during integration tests, but that involved materializing yaml deployment templates that are not suitable for distribution.

This PR rebuilds the yaml files from jsonnet, without the image policy = Never override.

This is what would happen if we released without this PR:
```
NAME                                        READY   STATUS              RESTARTS   AGE
sealed-secrets-controller-b85b85fd5-27f82   0/1     ErrImageNeverPull   0          21m
```

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
  • Loading branch information
bors[bot] and Marko Mikulicic committed Jul 22, 2019
2 parents 308619a + 37afe82 commit 727585b
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@ script:
kubectl rollout status deployment/sealed-secrets-controller -n kube-system -w
make integrationtest CONTROLLER_IMAGE=$CONTROLLER_IMAGE GINKGO="ginkgo -v --randomizeSuites --failOnPending --trace --progress --compilers=2 --nodes=4"
fi
# integration tests required Never pull policy, but release artifacts can't have that
# TODO(mkm): cleanup this.
- |
if [ "$TRAVIS_OS_NAME" = linux ]; then
rm -f controller.yaml controller-norbac.yaml
make controller.yaml controller-norbac.yaml CONTROLLER_IMAGE=$CONTROLLER_IMAGE
fi
after_script: set +e

Expand Down

0 comments on commit 727585b

Please sign in to comment.