Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter: account_tag for nick and channel #147

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented May 12, 2020

  • twitter account is accessible now either under <account_tag> nickname or through #<account_tag> channel
  • in contrast to status quo (twitter_ / #twitter_) it enables user to have a consistent namings, configurable by setting
    particular twitter account's tag
    Avoid sending pings every time a new message is send in the twitter channel and only when the nick is nickname is mentioned.

Credit goes to @mkoskar (https://bugs.bitlbee.org/ticket/1173).
Rebased on current git

@dequis
Copy link
Member

dequis commented May 12, 2020

As I wrote there:

While the idea behind the patch is good, there should be some way to keep previously added accounts under the old style channel names. Not entirely sure how, other than making this behavior optional under a setting.

To reply to your comment:

Maybe set the default tag of the twitter account to tag_?

Changing the account's tag is a UX breaking change too.

@Thaodan
Copy link
Contributor Author

Thaodan commented Jul 15, 2022

I'm looking into this patch again to have it ready for merging.

I wonder important it is that things stay the same since this would imply that both behavior would need to stay.

Setting the tag to the for twitter accounts for new accounts would be a middle ground that doesn't break existing UX.

@jelmer jelmer marked this pull request as draft September 7, 2022 14:55
Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also rebase to enable github actions

- twitter account is accessible now either under <account_tag> nickname or through #<account_tag> channel
- in contrast to status quo (twitter_<handle> / #twitter_<handle>) it  enables user to have a consistent namings, configurable by setting
   particular twitter account's tag

Credit goes to @mkoskar.
Rebased on current git
@Thaodan
Copy link
Contributor Author

Thaodan commented Feb 11, 2023

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants