Rewrite DebugInfoActivity to M3 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sunkup
force-pushed
the
742-rewrite-debuginfoactivity-to-m3
branch
2 times, most recently
from
7f75943
to
577c8a3
Compare
sunkup
added
enhancement
sunkup
force-pushed
the
742-rewrite-debuginfoactivity-to-m3
branch
2 times, most recently
from
abb15af
to
543c740
Compare
4 tasks
rfc2822
force-pushed
the
main-ose
branch
17 times, most recently
from
47ef18b
to
39f8f2e
Compare
rfc2822
force-pushed
the
742-rewrite-debuginfoactivity-to-m3
branch
from
45adc4c
to
9b5f565
Compare
- create/handle Intent in Activity (may be replaced by NavGraph in future) - Activity: pass unpacked initial data to Screen - Screen: use hiltViewModel (adds hilt-navigation-compose dependency) to create model with initial data - Screen: use Column instead of LazyColumn
rfc2822
force-pushed
the
742-rewrite-debuginfoactivity-to-m3
branch
from
6863419
to
575ca0e
Compare
…remote resource selectable
rfc2822
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rewriting the DebugInfoActivity from M2 to M3, refactoring for more clarity, stability and test-ability at the same time.
Short description
As requested, I have not yet moved debug info generation into a data layer class. I have however added comments about this in the kdoc. Note, that I, however, moved the
IntentBuilderto the ViewModel too, which should probably go to another helper/convenience class, since it's seemingly used throughout the whole app.Enhancement
Refactoring
Checklist