Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DebugInfoActivity to M3 #742

Closed
3 tasks done
Tracked by #691
rfc2822 opened this issue Apr 21, 2024 · 1 comment · Fixed by #744
Closed
3 tasks done
Tracked by #691

Rewrite DebugInfoActivity to M3 #742

rfc2822 opened this issue Apr 21, 2024 · 1 comment · Fixed by #744
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Apr 21, 2024

(See #691)

I have chosen this Activity as one where not that much happens and I think it could be implemented quite "clean".

To start, I'd:

  • Convert M2 calls to M3 (without architectural changes)
  • Split into 3 files (Activity, Screen, Model, see Migrate to Material 3 (M3) #691 and for instance LoginActivity) without further changes
  • Change = MutableLiveData() to by mutableStateOf() for our own fields (that don't come from an external Flow) in the model

Then when this is done we can optimize the composable and models a bit and think whether we leave the rest as it is or whether further changes would be useful (like moving the debug info generation to a separate data layer class).

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Apr 21, 2024
@rfc2822 rfc2822 mentioned this issue Apr 21, 2024
12 tasks
@sunkup sunkup linked a pull request Apr 23, 2024 that will close this issue
4 tasks
@sunkup
Copy link
Member

sunkup commented Apr 24, 2024

  • Create and use a private set uiState data class in view model
  • move remaining screen logic to view model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants