Wallet: wrap more exceptions as "failedFuture" #3169
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure this is the right thing to do for `CompletionException`. I'm less sure for `IllegalArgumentException` and `IllegalStateException`. The `CompletionExceptions` cases need to be handled at runtime by wallet implementations and should show up as failed futures (so that callers don't have to test whether the future failed _and_ do a try-catch) for the "fatal" exceptions I'm not as sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is the right thing to do for
CompletionException. I'm less sure forIllegalArgumentExceptionandIllegalStateException.The
CompletionExceptionscases need to be handled at runtime by wallet implementations and should show up as failed futures (so that callers don't have to test whether the future failed and do a try-catch) for the "fatal" exceptions I'm not as sure.