Test the bitcoin v0.32.0-rc1 release
#1400
Conversation
Upgrade: - bitcoin to v0.31.0 - miniscript to v11.0.0 Note: The bitcoin upgrade includes improvements to the `Transaction::weight()` function, it appears those guys did good, we no longer need to add the 2 additional weight units "just in case".
crates/bdk/src/descriptor/policy.rs
Outdated
| sorted: bool, | ||
| secp: &SecpCtx, | ||
| ) -> Result<Option<Policy>, PolicyError> { | ||
| if threshold == 0 { | ||
| if threshold.k() == 0 { |
There was a problem hiding this comment.
This condition is impossible with the new threshold type.
There was a problem hiding this comment.
Removed - two instances.
Test the latest bitcoin release candidate. Includes bumping the version numbers so we can use this branch to test crates further up the stack.
|
@tcharding Are you planning on continuing working on this PR towards merge ? I'm asking just to know if I should start working on another one (on top of this one) on behalf of #1422 :) |
|
I"d love it if you took over. Feel free to use any of my work, change it, or drop it as you see fit. No attribution needed. FTR we need to get an updated version of |
Great, I'll do it then. Thanks, I'll follow the discussions on the PRs (rust-bitcoin/rust-bitcoincore-rpc#345 rust-bitcoin/rust-miniscript#679 repositories closely then. |
|
Hey @oleonardolima you should be good to go after this one goes in: rust-bitcoin/rust-miniscript#688 |
Please excuse the noise if this is not of interest to you guys right now. No action required from the
bdkteam - this is just informational and so therust-bitcointeam can see that bitcoin rc1 release is ok.Test the latest bitcoin release candidate. Includes an unreleased patched version of
rust-miniscript(masterbranch + depend on bitcoin rc release).Notes:
miniscript::Thresholdusage took me down a dark path for a while :)expectthat require more invasive error handling improvementsweight.to_wu() as usizeinstead of using the newWeighttype more thoroughlynetwork.into()liberally instead of using the newNetworkKindmore thoroughlySequence/RelLockTimestuff is a bit rough tooBut I believe this proves the rc1 release is pretty good as it is.
cargo test --color=always --workspace --all-features --all-targetspasses all tests on my machine.