Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(export): add tr descriptor #1393

Merged
merged 1 commit into from May 23, 2024
Merged

fix(export): add tr descriptor #1393

merged 1 commit into from May 23, 2024

Conversation

rustaceanrob
Copy link
Contributor

Description

Resolves #860 by adding export of taproot descriptors

Notes to the reviewers

Allows export as Core accepts taproot.

Changelog notice

  • Export taproot descriptors

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ValuedMammal
Copy link
Contributor

Concept ACK

storopoli
storopoli approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de51739

Simple change with an added test case.
Thanks!

oleonardolima
oleonardolima approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de51739 :shipit:

@oleonardolima
Copy link
Contributor

@notmandatory I think this one is missing the 1.0.0-alpha label, as it was on the #860, could you add to it, please ?

@notmandatory notmandatory modified the milestones: 1.0.0-beta, 1.0.0-alpha May 11, 2024
notmandatory
notmandatory approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1b7c6df

@notmandatory notmandatory merged commit a2d9401 into bitcoindevkit:master May 23, 2024
12 checks passed
@rustaceanrob rustaceanrob deleted the tr-export branch May 23, 2024 16:35
@notmandatory notmandatory mentioned this pull request May 23, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

@storopoli storopoli storopoli approved these changes

Assignees

@rustaceanrob rustaceanrob

Labels
module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rustaceanrob @ValuedMammal @oleonardolima @notmandatory @storopoli