Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdk_hwi, set cargo bdk version to 1.0.0-alpha.8 #1392

Closed

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 27, 2024

Description

Need to set a specific version for the bdk_wallet dependency in order to be able to publish bdk_hwi to crates.io. I also added a README file since it is also a warning if a crate is published without one.

cargo publish -p bdk_hwi
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `bdk` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Mar 27, 2024
@notmandatory notmandatory added the dependencies Pull requests that update a dependency file label Mar 27, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Mar 27, 2024
@notmandatory notmandatory mentioned this pull request Mar 27, 2024
25 tasks
@notmandatory notmandatory removed the request for review from danielabrozzoni May 18, 2024 02:34
@notmandatory
Copy link
Member Author

Will make these fixes in #1449.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant