Improve fee sniping deterrence [BIP326] #1251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two tests to wallet.rs. In `test_create_tx_fee_sniping_tr` we check that for a taproot transaction with rbf enabled, either the tx LockTime is set to the most recent checkpoint, or the input's Sequence is set to its confirmations (allowing for randomness in both cases). In `test_create_tx_fee_sniping_tr_csv` we check that policy csv requirements take precedence over a default nSequence. A new test descriptor getter is added to common.rs `get_test_tr_with_taptree_csv` that contains a script path with a csv condition.
ValuedMammal
commented
Mar 14, 2024
| // Occasionally, randomly pick a lower sequence. | ||
| confs = confs.saturating_sub(rng.gen_range(0u16..100)); | ||
| } | ||
| transaction.input[idx].sequence = Sequence::from_height(confs); |
There was a problem hiding this comment.
This needs to find the input corresponding to the randomly selected utxo above, rather than assume the same idx
|
@ValuedMammal since lightning doesn't us taproot yet is there a strong motivation for doing this now? |
|
I propose we push to to a post 1.0 release since it's a functional improvement that shouldn't change the current wallet API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First attempt at bip326
for reference:
BIP326
Bitcoin Core
Sparrow
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingcloses #1134