-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rust-bitcoin to 0.32 #1422
Upgrade rust-bitcoin to 0.32 #1422
Comments
I'm willing to give a try on this one. |
Thanks @oleonardolima you'll need to keep an eye to see when rust-miniscript and rust-bitcoincore-rpc are ready. Feel free to start making PRs for any of the crate that only need rust-bitcoin updated to 0.32. |
Another thing this PR should fix is the broken docs.rs for |
Sure, I'll keep an eye and initially start from other crates.
Cool, I'll check if it solves the docs once the PR is done. |
@notmandatory Would #1423 fix the docs.rs fail? - Oh I see you mentioned it wouldn't be needed after the rust-bitcoin upgrade. Still maybe a quick fix in the interim |
a577c22 fix(persist): add default feature to enable bdk_chain/std (Steve Myers) Pull request description: ### Description This PR adds a `default` feature to `bdk_persist` so it can be build on its own. Once #1422 is done we can remove the `default`again. ### Notes to the reviewers I need to be able to build `bdk_persist` on its own so I can publish it to crates.io. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK a577c22 oleonardolima: ACK a577c22 storopoli: ACK a577c22 Tree-SHA512: 8b07a9e4974dec8812ca19ce7226dcaece064270a0be8b83d3c326fdf1e89b051eb0bd8aa0eda9362b2c8233ecd6003b70c92ee046603973d8d40611418c3841
I forgot to mention there was a suggestion #1412 (comment) for a better crate description for |
update: Some of the rust-bitcoin crates have been released, and the
EDIT: habemus |
Describe the enhancement
The LDK team would like to use
rust-bitcoin
version 0.32 so BDK should update too. To do so we also need to update the following crates to the versions that depend onrust-bitcoin
0.32:Use case
Updating to
rust-bitcoin
0.32 removes the need for a specificno-std
feature, it will be implied by not enabling thestd
feature. It also includes a new io crate.Additional context
https://discord.com/channels/753336465005608961/753367451319926827/1228314439133171795
The text was updated successfully, but these errors were encountered: