Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Replace ifname check with IFF_LOOPBACK in Discover #29984

Merged
merged 2 commits into from May 7, 2024
Merged

net: Replace ifname check with IFF_LOOPBACK in Discover #29984

merged 2 commits into from May 7, 2024

Commits on Apr 28, 2024

  1. net: Replace ifname check with IFF_LOOPBACK in Discover 

    Checking the interface name is kind of brittle. In the age of network
namespaces and containers, there is no reason a loopback interface can't
be called differently.

Check for the `IFF_LOOPBACK` flag to detect loopback interface instead.
    @laanwj
    laanwj committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7766dd2 View commit details
    Browse the repository at this point in the history

  2. net: Fix misleading comment for Discover 

    All network addresses are being iterated over and added, not just the first one per interface.
    @laanwj
    laanwj committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    a68fed1 View commit details
    Browse the repository at this point in the history