msvc: Compile test\fuzz\bitdeque.cpp
#29983
Merged
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
changed the title
test\fuzz\bitdeque.cpptest\fuzz\bitdeque.cpp
|
cc @sipa |
|
lgtm ACK 774359b |
dergoegge
approved these changes
Apr 30, 2024
|
utACK 774359b |
|
ACK 774359b Tested on windows, the bitdeque fuzz target is indeed now available. |
|
Ported to the CMake-based build system in hebasto#182. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 3, 2024
fc91bfe fixup! cmake: Add fuzzing options (Hennadii Stepanov) 5927338 fixup! cmake: Add platform-specific definitions and properties (Hennadii Stepanov) dcf2e66 refactor: Make 64-bit shift explicit (Hennadii Stepanov) a7edea8 refactor: Fix "error C2248: cannot access private member" on MSVC (Hennadii Stepanov) Pull request description: This PR ports bitcoin#29774 after the recent sync/rebase [PR](#179). Also included changes from bitcoin#29983. Top commit has no ACKs. Tree-SHA512: 562919ec9b89401d193c6d59a8634f5086a1a063b6ee075c465c5dbc9bf59da4bb1eb7b826deac91f470e22fe9bf049b43b7106bdc66c5d26c715d68a1008f4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves one point from the #29774 (comment):