Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: txorphan tests fixups #29974

Merged
merged 1 commit into from May 13, 2024
Merged

Commits on May 1, 2024

  1. fuzz: txorphan tests fixups

    Adds the following fixups in txorphan fuzz tests:
    
    - Don't bond the output count of the created orphans based on the number of available coins
    - Allow duplicate inputs, when applicable, but don't store duplicate outpoints
    
    Rationale
    ---------
    
    The way the test is currently written, duplicate inputs are allowed based on a random flag (`duplicate_input`).
    If the flag is unset, upon selecting an outpoint as input for a new transaction, the input is popped to prevent re-selection,
    and later re-added to the collection (once all inputs have been picked). However, the re-addition to the collection is performed independently of whether the flag was set or not.
    This means that, if the flag is set, the selected inputs are duplicated which in turn makes these inputs more likely to be re-picked in the following iteration of the loop.
    
    Additionally, both the input and output count of the transaction and bonded to the number of available outpoints. This makes sense for the former, but the latter shouldn't be.
    sr-gi committed May 1, 2024
    Configuration menu
    Copy the full SHA
    58594c7 View commit details
    Browse the repository at this point in the history