Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Assumeutxo: ensure failure when importing a snapshot twice #29973

Merged

Conversation

alfonsoromanz
Copy link
Contributor

I am getting familiar with the assume_utxo tests and I found that the scenario of trying to activate a snapshot twice is not covered. This test is to ensure failure when loading a snapshot if there is already a snapshot-based chainstate.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 26, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fjahr, rkrux, kevkevinpal, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fjahr
Copy link
Contributor

fjahr commented Apr 26, 2024

test/functional/feature_assumeutxo.py:401:1: W293 blank line contains whitespace
^---- failure generated from lint-python.py

@fjahr
Copy link
Contributor

fjahr commented Apr 26, 2024

Concept ACK

@alfonsoromanz alfonsoromanz force-pushed the assumeutxo-test-import-snapshot-twice branch from 9b75541 to b259b0e Compare April 26, 2024 13:50
@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/24300439204

@alfonsoromanz
Copy link
Contributor Author

alfonsoromanz commented Apr 26, 2024

test/functional/feature_assumeutxo.py:401:1: W293 blank line contains whitespace
^---- failure generated from lint-python.py

Thanks @fjahr. I just fixed the linting issue.

@fjahr
Copy link
Contributor

fjahr commented Apr 26, 2024

Code review ACK b259b0e

@alfonsoromanz alfonsoromanz changed the title [Test] Assumeutxo: ensure failure when importing a snapshot twice test: Assumeutxo: ensure failure when importing a snapshot twice Apr 26, 2024
@DrahtBot DrahtBot added Tests and removed CI failed labels Apr 26, 2024
Copy link

@rkrux rkrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b259b0e

Make successful, all functional tests pass.
Short and to the point PR.

test/functional/feature_assumeutxo.py Show resolved Hide resolved
@kevkevinpal
Copy link
Contributor

tACK b259b0e

made a similar PR not knowing this existed #30068

@achow101
Copy link
Member

achow101 commented May 9, 2024

ACK b259b0e

@achow101 achow101 merged commit 921c61e into bitcoin:master May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants