Lint: support running individual rust linters and improve subtree exclusion #29965
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
The Win64 GHA test failure looks unrelated. If you want, you can split up 54b2115 into its own pull request, as it is an independent improvement. But up to you. |
|
I think I will leave it in here since the motivation for 54b2115 is mostly the increased number of lint checks only accessible through the lint test runner. But I will split it out if anyone has an objection, or if this PR stalls. |
Add support for passing `--lint=LINT_TO_RUN` to the lint runner and add corresponding help message.
This makes all the lint checks written in rust exclude subtrees, and refactors the exclusion lists into a separate file.
Make the include guard linter print all warnings before exiting, and reuse common exclusion logic to improve subtree exclusion (crypto/ctaes was previously not excluded)
Rewrites the 'includes' linter to make use of common exclusion logic, improving subtree exclusion. (crypto/ctaes was previously not excluded)
This commit rewrites the spelling linter to reuse common
exclusion logic and improves subtree exclusion. ('crypto/ctaes' was
previously not excluded)
This commit rewrites the locale linter to reuse common exclusion logic and improves subtree exclusion (src/crc32c was previously not excluded)
Rewrites the python encoding lint check to make use of common exclusion logic.
|
Windows CI appears to have timed out, rebased to get a fresh CI run. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
This PR improves subtree exclusion by rewriting lint checks to reuse common exclusion logic. Most lint checks previously did not exclude
crypto/ctaes, the locale linter did not excludesrc/crc32Makes the include guards lint check print all missing include guards before exiting.
Adds support for running individual linters by passing
--lint=LINT_CHECK_TO_RUNto the lint runner. If using cargo run arguments can be passed e.g.:Supercedes #29744