Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove remaining unused code from cpp-subprocess #29961

Merged
merged 4 commits into from May 2, 2024
Merged

refactor: remove remaining unused code from cpp-subprocess #29961

merged 4 commits into from May 2, 2024

Commits on Apr 25, 2024

  1. remove unused templates from cpp-subprocess 

    The templates `is_ready`, `param_pack`, and `has_type` are not used
anywhere, so let's remove them.
    @theStack
    theStack committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ff79adb View commit details
    Browse the repository at this point in the history

  2. remove commented out code in cpp-subprocess

    @theStack
    theStack committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    908c51f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. remove unused method Popen::kill from cpp-subprocess

    @theStack
    theStack committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    97f1597 View commit details
    Browse the repository at this point in the history

  2. update comments in cpp-subprocess (check_output references) 

    Remove obsolete `check_output` references in the comments and remove
the numbering of the Popen API methods, as they don't seem to provide a
value and just make diffs larger for future changes.
    @theStack
    theStack committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8b52e7f View commit details
    Browse the repository at this point in the history