New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps #29959
base: master
Are you sure you want to change the base?
Conversation
Doesn't cause problems because we don't use FT on windows, but leave it alone just to be sure.
We don't use the libinput platform, and we don't really care about it (it's for very low level embedded devices use, which render on the screen without windowing env). Remove unnecessary code from the patch.
No need to defer this, simplifies initialization.
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Concept ACK on this. Obviously :) |
2339d21
to
d21b27e
Compare
d21b27e
to
82ed822
Compare
🐙 This pull request conflicts with the target branch and needs rebase. |
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a
bitcoin-qt
binary that "just works" on systems that have only one of them installed, or both.Everything (including libEGL) is loaded dynamically at run time if needed.
(
libdl.so.1
also when building with older GLIBC, as for guix)When launching with
WAYLAND_DISPLAY=...
(takes priority):When launching with
DISPLAY=...
:Will make this a draft. This is not ready for review: the Qt patch can potentially be cleaned up a lot with regard to generated wayland code. But it works. Please review #29923 instead, which needs to go in first anyway.
Closes #19950.
qtsowrap
wayland branch: https://github.com/laanwj/qtsowrap/tree/waylandCo-authored-by: Hennadii Stepanov
Notes
qtwayland-...
is missing while runningmake
independs
, remove thedepends/sources/.download-stamps/.*qt*
files to make sure it re-attempts to download missing files.