[27.x] Backports #29888
Merged
[27.x] Backports #29888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`, but then linking is done with `x86_64-w64-mingw32-g++`. I'm guessing this has been broken since bitcoin#24131 (01d1845), but have not checked. Fixes bitcoin#29734. Unblocks bitcoin#29527 (now DEBUG=1 builds can be tested). Github-Pull: bitcoin#29747 Rebased-From: b7e7e72
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed. Github-Pull: bitcoin#29691 Rebased-From: 4f273ab
Re-enable feature_init Github-Pull: bitcoin#29856 Rebased-From: fadf7e9
Github-Pull: bitcoin#29869 Rebased-From: c2e0489
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced Apr 17, 2024
Github-Pull: bitcoin#29886 Rebased-From: c087549
Github-Pull: bitcoin#29892 Rebased-From: fa4c696
Github-Pull: bitcoin#29859 Rebased-From: dd3e0fa
fanquake
force-pushed
the
27_1_backports
branch
from
256c329
to
fe49299
Compare
Github-Pull: bitcoin#29870 Rebased-From: fa6ab0d
fanquake
force-pushed
the
27_1_backports
branch
from
fe49299
to
29892c7
Compare
The script provided for signature might be externally provided, for instance by way of 'finalizepsbt'. Therefore the script might be ill-crafted, so don't assume pubkeys are always 32 bytes. Thanks to Niklas for finding this. Github-Pull: bitcoin#29853 Rebased-From: 4d8d213
fanquake
force-pushed
the
27_1_backports
branch
from
29892c7
to
d70daed
Compare
Github-Pull: bitcoin#29776 Rebased-From: bbe82c1
fanquake
force-pushed
the
27_1_backports
branch
from
d70daed
to
74f1e92
Compare
The 32 to 64-bit time_t transition causes a build failure in the built-in zlib about conflicting _TIME_BITS and _FILE_OFFSET_BITS. Note that zlib doesn't use time_t at all, so it is a false alarm. Take the following patch from upstream zlib: https://github.com/madler/zlib/commit/a566e156b3fa07b566ddbf6801b517a9dba04fa3.patch Closes bitcoin#29980. Github-Pull: bitcoin#29985 Rebased-From: 2e266f3
fanquake
force-pushed
the
27_1_backports
branch
from
74f1e92
to
cdc6e12
Compare
Github-Pull: bitcoin#29934 Rebased-From: 2257404
willcl-ark
reviewed
May 9, 2024
willcl-ark
approved these changes
May 9, 2024
There was a problem hiding this comment.
ACK 4689006
Without my earlier misunderstanding, this all looks good to me.
|
reACK bd5860b |
|
I suggest to add bitcoin-core/gui#812 and bitcoin-core/gui#813. |
I'll put these into the next PR, that will likely also do release prep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
CHECK_ATOMICtest #29859