New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use std::span over Span #29119
base: master
Are you sure you want to change the base?
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
#include <type_traits> | ||
#include <span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double include
1745cf8
to
99364d7
Compare
99364d7
to
0bb7722
Compare
2936a4a
to
d62c3a4
Compare
d62c3a4
to
449a307
Compare
449a307
to
b7d9f25
Compare
b7d9f25
to
b80b8ec
Compare
🐙 This pull request conflicts with the target branch and needs rebase. |
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
std::span
allows static extents, which is a nice benefit over justSpan
.However, the interface of the two isn't identical and requires some more changes than just defining an alias. This is my current draft to compile with
std::span
. This should be the minimal changes required to get a green CI, but the changes may not be ideal, so this remains a draft.Also, this requires and is based on #29071, which is blocked on OSS-Fuzz.
In the meantime, changes that make sense on their own, can be split up.