Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix bugprone-lambda-function-name errors #28737

Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Oct 26, 2023

Inside a lambda, __func__ will evaluate to something like "operator()". Fix this by either removing it, or by using the real name.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone/lambda-function-name.html

Can be reviewed with

--color-moved=dimmed-zebra
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 26, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, darosior

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28676 ([WIP] Cluster mempool implementation by sdaftuar)
  • #28391 (refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access by TheCharlatan)
  • #28335 (RFC: Remove boost usage from kernel api / headers by TheCharlatan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko changed the title Fix bugprone-lambda-function-name errors doc: Fix bugprone-lambda-function-name errors Oct 26, 2023
@DrahtBot DrahtBot added the Docs label Oct 26, 2023
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa769d

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK faa769d

@fanquake fanquake merged commit 6391644 into bitcoin:master Oct 30, 2023
16 checks passed
@maflcko maflcko deleted the 2310-bugprone-lambda-function-name- branch October 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants