Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP352: fix link to coredev discussion #1594

Merged
merged 1 commit into from
May 13, 2024
Merged

BIP352: fix link to coredev discussion #1594

merged 1 commit into from
May 13, 2024

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented May 12, 2024 •
edited

The current link is a redirect, which can be blocked by browsers or require user action.

@kanzure
Copy link
Contributor

kanzure commented May 13, 2024

ACK f4693dc

josibake
josibake approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@josibake josibake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4693dc

Might be worth adding a note about this somewhere, or even better having the lint script check for redirects (if that's possible).

murchandamus
murchandamus approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor fix, approved by Champion

@murchandamus murchandamus merged commit bc87508 into bitcoin:master May 13, 2024
3 checks passed
@jonatack jonatack deleted the 2024-05-bip352-coredev-link-fixup branch May 13, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murchandamus murchandamus murchandamus approved these changes

@josibake josibake josibake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jonatack @kanzure @murchandamus @josibake