ci: Update diff checks so that the task actually works #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murchandamus
reviewed
May 1, 2024
jonatack
reviewed
May 10, 2024
| @@ -8,6 +9,8 @@ if git checkout HEAD^ && scripts/buildtable.pl >/tmp/table.mediawiki 2>/dev/null | |||
| echo "$newdiff" | |||
| exit 1 | |||
There was a problem hiding this comment.
Not sure, but maybe seeing exits at this line on the CI and locally that appear to be false negatives on the first run, then green on the next one.
CI: https://github.com/bitcoin/bips/actions/runs/8977001323/job/24831359486#step:3:17
locally:
jon|(19a39e2...):~/bitcoin/bips$ git checkout origin/pr/1557
Previous HEAD position was 19a39e2 Fix links
HEAD is now at 2f620f5 Fix layer
jon|(2f620f5...):~/bitcoin/bips$ ./scripts/diffcheck.sh
Previous HEAD position was 2f620f5 Fix layer
HEAD is now at 1cf5983 Add information about service vendor
+++ /tmp/after.diff 2024-05-10 11:31:38
jon|(1cf5983...):~/bitcoin/bips$ ./scripts/diffcheck.sh
Previous HEAD position was 1cf5983 Add information about service vendor
HEAD is now at 19a39e2 Fix links
README table matches expected table from BIP files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Diff Checks CI task silently fails. This PR fixes that so it both works and the task will actually fail if the script is failing.
The failure was caused by 2 issues:
buildtable.plon the current commitAdditionally,
actions/checkout@v3is deprecated in favor ofactions/checkout@v4so this PR bumps that too.Lastly, since diff checks will fail for PRs that do not have numbers yet, I've clarified that this is expected in the CI task's name.