buildtable.pl: Also check .md files #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK
…On Wed, Apr 24, 2024 at 11:00 PM Ava Chow ***@***.***> wrote:
Adds markdown .md files to buildtable.pl so that it builds and checks
them too.
Since markdown allows html tags, the check for a <pre> tag is fine to
leave in; all .md formatted bips will be required to have a preamble
section like formatted in the same way as the mediawiki ones.
------------------------------
You can view, comment on, or merge this pull request online at:
#1577
Commit Summary
- 89755f0
<89755f0>
buildtable.pl: Also check .md files
File Changes
(1 file <https://github.com/bitcoin/bips/pull/1577/files>)
- *M* scripts/buildtable.pl
<https://github.com/bitcoin/bips/pull/1577/files#diff-7b2df03994b4e6ec1e61cde31a4311eaeb27439916ff5c6d2e955d52f0a4836c>
(3)
Patch Links:
- https://github.com/bitcoin/bips/pull/1577.patch
- https://github.com/bitcoin/bips/pull/1577.diff
—
Reply to this email directly, view it on GitHub
<#1577>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W2IDBOL5IZLXKHEEITY7A2QDAVCNFSM6AAAAABGXZIANCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DEMZSGE4TAOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Merged
|
I have verified that this change correctly discovers a markdown file instead of a mediawiki file and that the ACK 89755f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds markdown
.mdfiles tobuildtable.plso that it builds and checks them too.Since markdown allows html tags, the check for a
<pre>tag is fine to leave in; all.mdformatted bips will be required to have a preamble section like formatted in the same way as the mediawiki ones.