Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hebrew.txt #1565

Closed
wants to merge 3 commits into from
Closed

hebrew.txt #1565

wants to merge 3 commits into from

Conversation

ArielYaniv
Copy link

Incorporating list of 2048 Hebrew words, taken from the book of the Torah

Incorporating list of 2048 Hebrew words, taken from the book of the Torah
@murchandamus
Copy link
Contributor

Hey Ariel, perhaps you should work on your proposal in your own repository or offline, and only submit it here when it is complete. There are people that get an email each time you update your draft, and given that you seem to add one word at a time it would be nice to avoid the next 2040 emails. ;)

@ArielYaniv
Copy link
Author

ArielYaniv commented Apr 16, 2024 via email

@murchandamus
Copy link
Contributor

Hey @ArielYaniv, it has come to my attention that the author(s) of BIP 39 have decided not to accept any further word lists into BIP 39 itself, and encourage adding new ones to the WLIPs repo here: https://github.com/p2w34/wlips

I have asked for clarification on this from the authors of BIP39, but if BIP39 no longer accepts new wordlists, this PR may no longer be a good fit for the BIPs repository.

@ArielYaniv
Copy link
Author

@murchandamus Interesting... anyway We are going to continue with this proposal, I don't know how long it will take because Hebrew is the oldest language spoken today and it's important to make sure it stays the right way.

@murchandamus
Copy link
Contributor

This update sounds to me as if the BIP39 authors have generally restricted themselves to focus only on an English wordlist. I am afraid that I do not know where your wordlist should be submitted eventually, since neither BIP39 nor the WLIPs seem to be looking to incorporate further lists. Perhaps this would be a topic to discuss with other Hebrew speaking Bitcoin users.

I also noticed that there were at least two prior attempts to create a Hebrew word list. You may find p2w34/wlips#57 and p2w34/wlips#58 useful.

Since this PR does not seem to have a prospect of getting merged, it seems to me that it should probably be closed.

@jonatack jonatack closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants