bip-tombriar-compressed-transactions #1556
Open
+293
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Tom, Thanks for posting this. I'd suggest rewording the abstract and PR description to avoid talking in terms of Core internals (classes, subclasses, etc) and instead simply describe the serialization. It's fine to describe suggested RPC endpoints since these give an idea of how the specification might be used. |
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
| |- | ||
| ! Name !! Width !! Description | ||
| |- | ||
| | Compressed Signature || 1 Bit || Signature compression flag. For P2TR: 1 for keyspend, 0 for scriptspend; For P2SH: 0 for p2sh, 1 for p2sh-wpkh. |
There was a problem hiding this comment.
Maybe mention that for optut types other than P2TR and P2SH this bit is unused.
There was a problem hiding this comment.
It's used for all script types but has special implications for P2TR and P2SH-WPKH. I reworded for clarity.
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
apoelstra
reviewed
Mar 19, 2024
TomBriar
force-pushed
the
bip-tombriar-compressed-transactions
branch
3 times, most recently
from
be1f84e
to
e5af215
Compare
TomBriar
force-pushed
the
bip-tombriar-compressed-transactions
branch
from
e5af215
to
b6be561
Compare
murchandamus
requested changes
Apr 29, 2024
Comment on lines
+6
to
+7
| Comments-URI: https://github.com/bitcoin/bitcoin/pull/29134 | ||
| https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-August/021924.html |
There was a problem hiding this comment.
I think this is mixing up the "Comments-URI" and the "Post-History" headers.
Suggested change
| Comments-URI: https://github.com/bitcoin/bitcoin/pull/29134 | |
| https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-August/021924.html | |
| Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-tombriar-compressed-transactions |
| Status: Draft | ||
| Type: Standards Track | ||
| Created: 2024-02-01 | ||
| License: BSD-3-Clause |
There was a problem hiding this comment.
Suggested change
| License: BSD-3-Clause | |
| License: BSD-3-Clause | |
| Post-History: https://github.com/bitcoin/bitcoin/pull/29134 | |
| https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-August/021924.html |
| === Motivation === | ||
| Typical Bitcoin transactions usually contain a large amount of white space and padding due to specific fields that are often one of a minimal number of possibilities. We can use this fact and a few similar methods to create an encoding for 90% of Bitcoin transactions that are roughly 25-50% smaller. | ||
|
|
||
| === Rational === |
There was a problem hiding this comment.
Suggested change
| === Rational === | |
| === Rationale === |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document proposes a serialization scheme for compressing bitcoin transactions. The compressed bitcoin transactions can reach a serialized size of less than 50% of the original serialized transaction. One of the methods for compressing, involves reducing the transaction outpoints in a potentially lossy way, therefore it is an optional path for compression. Without compressing the outpoints, compressed transactions still reach less then 70% of the original size.
Reference Implementation:
bitcoin/bitcoin#29134
The reference implementation includes two new RPC endpoints to demonstrate how to use compressed transactions. The compressrawtransaction takes in a raw hex-encoded transaction and returns a compressed hex-encoded transaction, while the decompressrawtransaction accepts a compressed hex-encoded transaction and returns the original raw hex-encoded transaction.
Thanks-
Tom.