Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention explicitly that CTV does not commit to inputs #1475

Closed
wants to merge 1 commit into from

Conversation

OrfeasLitos
Copy link
Contributor

No description provided.

@luke-jr
Copy link
Member

luke-jr commented Jul 18, 2023

@JeremyRubin

@JeremyRubin
Copy link
Contributor

JeremyRubin commented Jul 18, 2023 via email

@OrfeasLitos
Copy link
Contributor Author

CTV is a template (as opposed to a full specification) precisely because it doesn't commit to the inputs. Input omission is one of the central design drivers of CTV, IIUC.

This change adds crucial intermediate-level intuition, which now the reader can only glean by a tedious process of elimination.

@JeremyRubin
Copy link
Contributor

The BIP currently has this text:

The set of data committed to is a superset of data which can impact the TXID of the transaction, other than the inputs.

@OrfeasLitos
Copy link
Contributor Author

It's tucked away halfway through the document though, after the specification. Also IMO this particular phrasing and the surrounding text does not highlight enough why leaving inputs out is one of the keys to CTV.

If there is an intention for the BIP to be readable by folks with less than full Bitcoin expertise, this central design choice should be mentioned together with other central design decisions, early on and clearly, not relegated with other implementation details.

I believe that making this technical document more accessible to a wider audience with little touches like the one proposed here will attract more supporters and help to expedite CTV adoption.

@JeremyRubin
Copy link
Contributor

JeremyRubin commented Jul 27, 2023 via email

Copy link
Contributor

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the BIP author, and more importantly, I doubt that an editor would merge this when the author is reluctant. Thank you for your suggestion, but let's not spend further time here.

@jonatack jonatack closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants