Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip-0324: fix git instruction order in test_sage_decoding.py #1471

Merged

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Jul 6, 2023

Tiny fix correcting the order of commands, for git checkout one has to change into the repository directory first.

Tiny fix correcting the order of commands, for `git checkout` one has
to change into the repository directory first.
@stratospher
Copy link
Contributor

(unrelated to this PR but related to BIP 324) - you could also remove https://github.com/bitcoin/bips/blob/master/bip-0324/xswiftec_test_vectors.csv maybe? xswiftec_test_vectors.csv isn't being used anywhere and I'd assume it's a leftover from the previous revision of the doc which replaced it with xswiftec_inv_test_vectors.csv(currently used).

@luke-jr
Copy link
Member

luke-jr commented Jul 9, 2023

@sipa
Copy link
Member

sipa commented Jul 9, 2023

LGTM

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f25645

@murchandamus murchandamus merged commit e641025 into bitcoin:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants