Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-174: add SLIP-0019 fields #1434

Closed
wants to merge 1 commit into from

Conversation

louneskmt
Copy link

The PSBT extension section of the SLIP-0019 has just been clarified and updated in satoshilabs/slips@019bcd6.

@murchandamus
Copy link
Contributor

@achow101: could you review this when you have a chance?

@achow101
Copy link
Member

achow101 commented May 1, 2024

Tend to NACK. IMO every non-proprietary PSBT field should be defined in a BIP. If you don't want to do that, use a proprietary field. I prefer to be very strict with that as otherwise we open up people to start defining their own fields and someone having to go and hunt down every unBIP'd usage of a field number, which is just an insane maintenance burden. We also want to avoid conflicting field numbers, so requiring everything to be a BIP will actually standardize what each field number means.

Note that field number 0x19 collides with proposed field numbers in #1540

@jonatack
Copy link
Contributor

jonatack commented May 1, 2024

Closing per BIP author feedback (thanks @achow101).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants