Skip to content

Commit

Permalink
Merge #1524: check-abi: explicitly provide public headers
Browse files Browse the repository at this point in the history
dd69556 check-abi: explicitly provide public headers (Jonas Nick)

Pull request description:

  Without this commit, the check-abi shell script outputs false positives because it consider some headers public that are actually not public.

ACKs for top commit:
  real-or-random:
    ACK dd69556
  hebasto:
    ACK dd69556, tested on Ubuntu 24.04.

Tree-SHA512: b26e61639061f5fbbdd47569ba04f91c627feeefc43ec3d529a3ac4012ab6487aa1904bd38100ed190dcaebdffe60895a8c99346720d5dee84a0c457ec3b6f94
  • Loading branch information
real-or-random committed May 7, 2024
2 parents 7d0bc08 + dd69556 commit 7712a53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/check-abi.sh
Expand Up @@ -49,7 +49,7 @@ checkout_and_build() {
-DSECP256K1_BUILD_CTIME_TESTS=OFF \
-DSECP256K1_BUILD_EXAMPLES=OFF
cmake --build . -j "$(nproc)"
abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2"
abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2" -public-headers ../include/
cd "$_orig_dir"
}

Expand Down

0 comments on commit 7712a53

Please sign in to comment.