Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection

[pablomartin4btc]

Currenlty on master, when the "mask values" checkbox is ticked if the user selects a different wallet, the history action is enable and if the user clicks on it can see all the transactions in the transaction view.

This PR fixes it.

Note for maintainers: this needs to be backported to 25.x and 26.x.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Stale ACK	alfonsoromanz

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #733 (Deniability - a tool to automatically improve coin ownership privacy by denavila)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[alfonsoromanz]

Tested ACK d3da502

[luke-jr]

This feels like the wrong place to fix it. Why not inside setWalletActionsEnabled (or whatever is enabling it to begin with)?

[pablomartin4btc]

This feels like the wrong place to fix it. Why not inside setWalletActionsEnabled (or whatever is enabling it to begin with)?

Yeah, it makes more sense, I'll rework it. Thanks!

[pablomartin4btc]

Updates:

• Addressed @luke-jr's feedback.

[luke-jr]

I'm pretty sure you can just modify the existing line in setWalletActionsEnabled to:

    historyAction->setEnabled(enabled && !isPrivacyModeActivated());

[pablomartin4btc]

    historyAction->setEnabled(enabled && !isPrivacyModeActivated());

Just replacing the operator with || (e.g. when the user closes all wallets, all tabs will be disabled except for Transactions).

[pablomartin4btc]

Updates:

• Addressed @luke-jr's feedback.

[luke-jr]

This one-line change works without anything else:

#815 (review)

[pablomartin4btc]

This one-line change works without anything else:

#815 (review)

Sorry, I made another mistake, thanks for double checking.

To other reviewers: please hold on till next push, thanks.

[pablomartin4btc]

Updates:

• Incorporated @luke-jr's suggestion, simplifying the fix.