Correct tooltip wording for watch-only wallets #792
Conversation
Make labelSpendable visible for watch only wallets with their private keys disabled. Also set the labelBalance accordingly for the same condition. Co-authored-by: saibato <saibato.naga@pm.me>
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
|
As a first commit, I only took @ saibato's latest commit and corrected a couple of bugs (mentioned by @pablomartin4btc in the original PR.) |
hebasto
changed the title
| ui->labelBalance->setText(BitcoinUnits::formatWithPrivacy(unit, balances.watch_only_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy)); | ||
| ui->labelBalance->setToolTip(tr("Your current balance in watch-only addresses")); |
There was a problem hiding this comment.
Despite the confusing interfaces, watch-only wallets are not based on addresses (or they would never see spends). Prefer to use less confusing language here.
There was a problem hiding this comment.
Perhaps "Your current watch-only balance" or "Your current watch-only wallet balance"?
|
Are you still working on this? |
I am active, and I'll resume working on this PR and upload a proposal soon. |
This is a continuation of #37
This is a simple change, but imho necessary because it leads to confusion.
The objective of this change is to provide a better description for the tooltip for the "Available Balance" balance because the current version on master mentions the word "You current spendable balance" which is a bit misleading, because that balance is not always spendable , or not always yours on watch only wallets.