Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix custom datadir doubleClick - Follow-up #392 #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablomartin4btc
Copy link
Contributor

This is a desktop-only (not mobile/ android) workaround to disable double-click on custom datadir which is on the StorageLocations.qml componennt.

Double-clicking was causing the file dialog to get open but losing focus and moving to the background, bringing upfront the main window which was useless because the file dialog is modal (issue raised originally by @MarnixCroes on PR #392 but still persists in ongoing PR #397).

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for picking this up.
it doesn't fully fix the problem.
I can still repro sometimes, like +- 1 out of 10 times.
(double-checked I'm not making an error, like accidentally having the second click change the focus.)

@pablomartin4btc
Copy link
Contributor Author

thanks for picking this up. it doesn't fully fix the problem. I can still repro sometimes, like +- 1 out of 10 times. (double-checked I'm not making an error, like accidentally having the second click change the focus.)

Ok, thanks for testing it promptly. I couldn't reproduce the issue on Ubuntu, are you on Mac?

If we can't fully fix it, I'd need to investigate another approach and close this one.

@MarnixCroes
Copy link
Contributor

are you on Mac?

no, Ubuntu 22.04.4 LTS

@pablomartin4btc
Copy link
Contributor Author

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

@MarnixCroes
Copy link
Contributor

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

I could repro with 150. (happened after 25 tries)
I could repro with 300, only after +- 100 tries

@pablomartin4btc
Copy link
Contributor Author

I could repro with 150. (happened after 25 tries)
I could repro with 300, only after +- 100 tries

Thanks for testing it again, let's discuss it tomorrow with the rest of the team on the devs call, so far we can have this as a workaround to solve this bug until we find a better approach.

@pablomartin4btc pablomartin4btc marked this pull request as draft May 1, 2024 21:37
@pablomartin4btc
Copy link
Contributor Author

Updates:

@pablomartin4btc pablomartin4btc marked this pull request as ready for review May 4, 2024 05:29
@pablomartin4btc
Copy link
Contributor Author

Updates:

This is a desktop-only (not mobile) workaround to disable doubleclick
on custom datadir which is on the StorageLocations.qml componennt.

Double-clicking was causing the file dialog to get open but losing
focus and moving to the background, bringing upfront the main
window which was useless because the file dialog is modal.
@pablomartin4btc pablomartin4btc force-pushed the qml-fix-custom-datadir-doubleclick branch from be402aa to 6fca787 Compare May 27, 2024 15:16
@pablomartin4btc
Copy link
Contributor Author

Rebased to refresh CIs (#402). No code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants