-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paint rounded caps at the start and end of the Blockclock dial #309
base: main
Are you sure you want to change the base?
Conversation
johnny9
commented
Mar 31, 2023
•
edited
edited
should base on 306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rounded edges might work a little more nicely here. I like how in the PR, the top hour indicator dot is covered. Looks cleaner, like the center line of segment starts at midnight/noon, and then the thickness of the line expands from that in all directions (hope that makes any sense, let me know if you want me to visualize it). Also, is it possible to turn the hour indicator dots into actual circles? They seem like small segments of the block circle right now. |
@GBKS we will have to patch the line caps within qt, we can do this for right now to get us a tiny bit closer to the designs. |
|
||
if (-1 * nextAngle + 90 > m_animating_max_angle) { | ||
nextAngle = -1 * m_animating_max_angle + 90; | ||
// end the loop early | ||
i = numberOfBlocks; | ||
} | ||
|
||
const qreal spanAngle = -1 * (startAngle - nextAngle) + gap; | ||
path.arcTo(bounds, startAngle, spanAngle); | ||
path.arcTo(gapBounds, nextAngle, gap * 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a start, this makes the gaps close to what we want them to be
path.arcTo(gapBounds, nextAngle, gap * 2); | |
path.arcTo(gapBounds, nextAngle, gap); |
Ping @johnny9 any update on the sizing issue here? |
36e6a93
to
d5a1724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.