Update #17
Update #17
Conversation
+ IPv6 + Custom IP lookup URL for IPv6/IPv4 + Update UI after IP changes
+ Zone support
+ Use internal ip + Hide SRV - Removed crash bug with old configs
Classes/CloudFlareAPI.cs
Outdated
| /// </summary> | ||
| public void updateRecords(JsonResponse fetchedRecords) | ||
| public List<Result> updateRecords(Get_dns_records_response fetchedRecords) |
There was a problem hiding this comment.
Class names should not contain underscores, please rename to GetDnsRecordsResponse
Classes/CloudFlareAPI.cs
Outdated
| { | ||
| //Skip over MX and CNAME records | ||
| //TODO: Dont skip them :) | ||
| if (fetchedRecords.response.recs.objs[i].type != "A") | ||
| bool NeedIp = false; |
There was a problem hiding this comment.
This can be merged into a switch, with default case.
case "A": // fall through.
case: "AAAA":
NeedIp = true;
default:
NeedIp = false;
Classes/CloudFlareAPI.cs
Outdated
| /// <summary> | ||
| /// Get the listed records from Cloudflare using their API | ||
| /// </summary> | ||
| /// <returns>JSON stream of records, null on error</returns> | ||
| public JsonResponse getCloudFlareRecords() | ||
| public Get_dns_records_response getCloudFlareRecords(string SelectedZone) |
There was a problem hiding this comment.
Avoid underscores in method names, recommend GetDnsRecordsResponse
| @@ -0,0 +1,280 @@ | |||
| using System; | |||
| @@ -0,0 +1,30 @@ | |||
| namespace CloudFlareDDNS.Classes.JsonObjects.Cloudflare | |||
There was a problem hiding this comment.
Rename to GetDnsRecordsResponse.cs
README.md
Outdated
|
|
||
| ## Support Me | ||
| [](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=CALMNQUWLZNYL) | ||
| <br /><br /> | ||
| ## Requirements | ||
| ####OS Support | ||
| * Client: Windows XP / Vista / 7 / 8 / 8.1 |
There was a problem hiding this comment.
See comment above regarding .NET support.
README.md
Outdated
| .NET Framework 4.0 or above is required (already installed on Windows 8 / 8.1 / 2012 / 2012R2). | ||
| https://www.microsoft.com/en-gb/download/details.aspx?id=17851 | ||
| .NET Framework 4.7 or above is required (already installed on Windows 8 / 8.1 / 2012 / 2012R2). | ||
| https://www.microsoft.com/en-us/download/details.aspx?id=55170 | ||
| <br /><br /> | ||
| ## Building | ||
| Solution is known to build with Visual Studio 2013 (Community, Pro and Ultimate tested, Express should work), no additional dependencies are needed.<br /> |
There was a problem hiding this comment.
See comment above regarding VS2013 support.
| @@ -0,0 +1,3 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
packages.config
Outdated
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
See comment above regarding native alternatives.
| @@ -0,0 +1,20 @@ | |||
| The MIT License (MIT) | |||
There was a problem hiding this comment.
If this is required - I don't want it in the repository.
Please bring it in as a git submodule, or some other NuGet magic?
Just slow it down a bit
# Right click on entry -Force Update #Main Table - Last Change - Changing IP text
try too fix a crash in the settings
Fix authorization errors and two other small bugs
New Functions:
Updates