Adapt util.unique tests for numpy 1.21 #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy.unique changed behaviour in 1.21. Since 1.21 it treats all NaNs as the same value; before, it outputted as many NaNs as there were in the input array. Orange's util.unique functions is a thin wrapper around around numpy.unique. Because TestUnique used a test array with 2 NaNs the results were different depending on the version. Now they use a single NaN value.
Codecov Report
@@ Coverage Diff @@
## master #5508 +/- ##
==========================================
- Coverage 86.36% 86.36% -0.01%
==========================================
Files 304 304
Lines 61665 61665
==========================================
- Hits 53255 53254 -1
- Misses 8410 8411 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Tests on numpy 1.21 fail.
numpy.uniquechanged behaviour in 1.21. Since 1.21 it treats all NaNs as the same value; before, it outputted as many NaNs as there were in the input array. The corresponding numpy issue: numpy/numpy#2111Description of changes
Orange's
util.uniquefunction is a thin wrapper aroundnumpy.unique. Because TestUnique used a test array with 2 NaNs the results were different depending on the version. Now they use a single NaN value.Includes