Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Network from Distances #268

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 26, 2023

Issue

Fixes #250. Fixes #248. Fixes #243.

Description of changes

Reimplementation of Network from Distances. Widget is cleaner and leaner.

  • The new implementation allows setting the number of edges or density (or threshold, as before). All of these can be edited numerically or set in a graph.
  • The widget handles asymmetric matrices (should we have any).
  • Instead of histogram with number of edges at a particular distances, the graph is now cumulative; this allows for showing the threshold and the number of edges in the same graph.
  • Creating network of closest neighbors is removed to a separate widget.
  • Extracting the largest components / removal of small components is not longer possible. It may resurrect in a separate widget, dedicated to selection of components.
  • Better tests.

Network of Neighbours: A new widget with functionality that used to clutter the Network from Distances widget.

Screenshot 2023-12-26 at 12 47 03

TODO: Documentation will be written upon approval by @ajdapretnar. Preferably, it would be written by @ajdapretnar, thanks in advance. :)

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9279386) 73.76% compared to head (aa6f2fc) 76.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   73.76%   76.04%   +2.27%     
==========================================
  Files          21       23       +2     
  Lines        2977     3085     +108     
==========================================
+ Hits         2196     2346     +150     
+ Misses        781      739      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd force-pushed the reimplement-from-distances branch 2 times, most recently from 4f14c00 to 7efc865 Compare January 12, 2024 18:17
@ajdapretnar
Copy link
Contributor

I love it. I'll write the docs separately, if that's ok?

@ajdapretnar ajdapretnar merged commit a13cb52 into biolab:master Feb 23, 2024
12 checks passed
@janezd
Copy link
Contributor Author

janezd commented Feb 23, 2024

I love it. I'll write the docs separately, if that's ok?

Sure. I wrote an issue lest we forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants