Network Explorer: Replace (crashing) threads with ConcurrentMixin #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 73.76% 74.10% +0.33%
==========================================
Files 21 21
Lines 2977 3000 +23
==========================================
+ Hits 2196 2223 +27
+ Misses 781 777 -4 ☔ View full report in Codecov by Sentry. |
janezd
force-pushed
the
fr-thread-mixin
branch
from
af18217
to
13e453a
Compare
janezd
force-pushed
the
fr-thread-mixin
branch
from
13e453a
to
bc4cfa8
Compare
|
When I disconnect the input, comboboxes and outputs are not reset.
|
VesnaT
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Probably a Qt6 issue...
Traceback (most recent call last):
File "/Users/vesna/orange3-network/orangecontrib/network/widgets/graphview.py", line 133, in paint
pen.setWidth(w)
TypeError: setWidth(self, width: int): argument 1 has unexpected type 'numpy.float64'
| network_too_large = widget.Msg("Network is too large to visualize.") | ||
| single_node_graph = widget.Msg("I don't do single-node graphs today.") | ||
| network_too_large = Msg("Network is too large to visualize.") | ||
| single_node_graph = Msg("I don't do single-node graphs today.") |
There was a problem hiding this comment.
single_node_graph is never used.
janezd
force-pushed
the
fr-thread-mixin
branch
from
bc4cfa8
to
d041e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #238. Fixes #219. Fixes #190.
Description of changes
ConcurrentMixininstead of (incorrect) threads created in the widget code.np.int32, as expected by Cython code. The network can, in principle, have edges in, e.g.np.int64. (The bug was discovered when Network of Neighbors had return a net with such dtype.)Includes