Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] signals: Explicit insert/remove handlers #78

Merged
merged 21 commits into from
Apr 1, 2021

Conversation

ales-erjavec
Copy link
Collaborator

@ales-erjavec ales-erjavec commented Jun 17, 2020

Issue

Ref: biolab/orange-canvas-core#86

Requires biolab/orange-canvas-core#161 to be merged and released.

Description of changes

Add a new MultiInput description to managed explicitly ordered sequence of (multiple) inputs.

i.e.

...
class Inputs:
    foo = MultiInput(...)
...
@Inputs.foo
def set_foo(self, index, foo):
   self.foo[index] = foo

@Inputs.foo.insert
def insert_foo(self, index, foo):
    self.foo.insert(index, foo)

@Inputs.foo.remove
def remove_foo(self.index)
    self.foo.pop(index)
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 3 times, most recently from e5d7daa to a4f54e7 Compare June 22, 2020 09:50
@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 2 times, most recently from 10df67d to 26479fe Compare June 29, 2020 13:46
@janezd janezd self-assigned this Sep 4, 2020
@ales-erjavec
Copy link
Collaborator Author

Unfortunately this solution would not properly handle undo/redo in canvas: biolab/orange-canvas-core#118. It can only 'communicate' link appends not inserts.

@janezd janezd removed their assignment Sep 4, 2020
@ales-erjavec ales-erjavec marked this pull request as draft September 4, 2020 12:03
@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 2 times, most recently from b856768 to 1ab4e2a Compare December 16, 2020 11:20
@ales-erjavec ales-erjavec changed the title [RFC][ENH] OWBaseWidget: Explicit 'Closed' link signal (disconnect) [RFC][ENH] signals: Explicit insert/remove handlers Dec 17, 2020
@ales-erjavec ales-erjavec marked this pull request as ready for review December 22, 2020 08:24
@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 3 times, most recently from 97c57fe to aab3daf Compare December 28, 2020 11:37
@ales-erjavec ales-erjavec deleted the explicit-close-signal branch January 22, 2021 14:53
@ales-erjavec ales-erjavec reopened this Jan 22, 2021
@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 2 times, most recently from 9b6b45c to d8eeade Compare January 28, 2021 08:28
@markotoplak
Copy link
Member

The concept of the solution looks good to me.

@ales-erjavec, is this still RFC or could it be merged after canvas-core release?

@ales-erjavec ales-erjavec changed the title [RFC][ENH] signals: Explicit insert/remove handlers [ENH] signals: Explicit insert/remove handlers Feb 4, 2021
@janezd janezd assigned markotoplak and unassigned markotoplak Feb 5, 2021
@janezd janezd added needs discussion Core developers need to discuss the issue and removed needs discussion Core developers need to discuss the issue labels Mar 5, 2021
@ales-erjavec ales-erjavec force-pushed the explicit-close-signal branch 2 times, most recently from 7fa112f to 76e4ad2 Compare March 18, 2021 08:39
@markotoplak markotoplak merged commit 07416f7 into biolab:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants