-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] signals: Explicit insert/remove handlers #78
Merged
markotoplak
merged 21 commits into
biolab:master
from
ales-erjavec:explicit-close-signal
Apr 1, 2021
Merged
[ENH] signals: Explicit insert/remove handlers #78
markotoplak
merged 21 commits into
biolab:master
from
ales-erjavec:explicit-close-signal
Apr 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ales-erjavec
force-pushed
the
explicit-close-signal
branch
3 times, most recently
from
June 22, 2020 09:50
e5d7daa
to
a4f54e7
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
June 29, 2020 13:46
10df67d
to
26479fe
Compare
Unfortunately this solution would not properly handle undo/redo in canvas: biolab/orange-canvas-core#118. It can only 'communicate' link appends not inserts. |
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
November 9, 2020 12:04
26479fe
to
5278f47
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
December 16, 2020 11:20
b856768
to
1ab4e2a
Compare
ales-erjavec
changed the title
[RFC][ENH] OWBaseWidget: Explicit 'Closed' link signal (disconnect)
[RFC][ENH] signals: Explicit insert/remove handlers
Dec 17, 2020
ales-erjavec
force-pushed
the
explicit-close-signal
branch
3 times, most recently
from
December 28, 2020 11:37
97c57fe
to
aab3daf
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
January 28, 2021 08:28
9b6b45c
to
d8eeade
Compare
The concept of the solution looks good to me. @ales-erjavec, is this still RFC or could it be merged after canvas-core release? |
ales-erjavec
changed the title
[RFC][ENH] signals: Explicit insert/remove handlers
[ENH] signals: Explicit insert/remove handlers
Feb 4, 2021
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
February 11, 2021 14:49
d8eeade
to
91da497
Compare
janezd
added
needs discussion
Core developers need to discuss the issue
and removed
needs discussion
Core developers need to discuss the issue
labels
Mar 5, 2021
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
March 18, 2021 08:39
7fa112f
to
76e4ad2
Compare
Allow OWBaseWidget subclasses to override default 'input setter' behaviour/protocol.
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
March 22, 2021 11:53
95dc4d6
to
c2add16
Compare
Should have been removed in the orange-widget-base split from Orange. It is defined in Orange and should be imported from there.
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
March 30, 2021 07:39
c2add16
to
caccdd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: biolab/orange-canvas-core#86
Requires biolab/orange-canvas-core#161 to be merged and released.
Description of changes
Add a new
MultiInput
description to managed explicitly ordered sequence of (multiple) inputs.i.e.
Includes