Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category discovery: Improve logic for determining category name #267

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Apr 20, 2023

This PR changes the resolving the category name to follow this order,

  • NAME from package globals,
  • entry point from setup.py,
  • the name deduced from qualified package name. This used to take the last part, but this is usually "widgets". Now it takes the penultimate part in that case.

Previously, the first two points were reversed. I think package globals should have precedence because they are explicit.

Besides, the entry point is always defined (has to be, AFAIK), so the name from package globals was ignored. As result, we couldn't translate category names.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage: 26.66% and project coverage change: -0.04 ⚠️

Comparison is base (61fe8c1) 74.91% compared to head (52b800a) 74.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   74.91%   74.88%   -0.04%     
==========================================
  Files          97       97              
  Lines       20696    20705       +9     
==========================================
  Hits        15504    15504              
- Misses       5192     5201       +9     
Impacted Files Coverage Δ
orangecanvas/registry/discovery.py 38.28% <15.38%> (-0.97%) ⬇️
orangecanvas/registry/utils.py 93.65% <100.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ales-erjavec ales-erjavec merged commit 213add3 into biolab:master Apr 21, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants